Unified setDark API. Happens to take care of meta
#5483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are 2 problems this PR want to address:
<meta>tags to inform themui.dark_modeis hard-coded to useQuasar.Dark.setwhich gets in the way of using other UI frameworks than Quasar (Let configure UI framework other than Quasar #4859)Real motivation: to experiment, since I have doubts over "demo is good enough instead of API addition" #5471 (comment)
Implementation
Quasar.Dark.setwill never be called directly: It will be wrapped to take true/false/undefined, then set asdarkSetterdarkSettercan be another UI library's dark mode function, if you need that.setDarkcalls thedarkSetterwhile also handles the<meta>tags for you.<meta>tags are also populated in HTML.Progress