Replace dirname( __FILE__ ) calls with __DIR__ magic constant#187
Merged
peterwilsoncc merged 2 commits into10up:developfrom Mar 14, 2025
Merged
Replace dirname( __FILE__ ) calls with __DIR__ magic constant#187peterwilsoncc merged 2 commits into10up:developfrom
peterwilsoncc merged 2 commits into10up:developfrom
Conversation
jeffpaul
requested review from
peterwilsoncc
and removed request for
dkotter and
jeffpaul
peterwilsoncc
approved these changes
Mar 14, 2025
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me, thank you!
I've confirmed this covers all the instances in which the pattern is used.
github-project-automation
Bot
moved this from Code Review
to QA Testing
in Open Source Practice
github-project-automation
Bot
moved this from QA Testing
to Done
in Open Source Practice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
PHP 5.3 introduced the magic constant
__DIR__which is equivalent todirname( __FILE__ )and more efficient to use.Changelog Entry
Credits
Props @Soean
Checklist: