Skip to content

fix test for mixtral logit#2958

Merged
copybara-service[bot] merged 1 commit intomainfrom
shuningjin-xlml
Jan 16, 2026
Merged

fix test for mixtral logit#2958
copybara-service[bot] merged 1 commit intomainfrom
shuningjin-xlml

Conversation

@shuningjin
Copy link
Collaborator

@shuningjin shuningjin commented Jan 16, 2026

Description

Fix mixtral-8x7b forward logit check for XLML test

  • Previous PR changes the criteria from --atol=3 --rtol=1 to --max_kl_div=2e-3, which is too strict.
AssertionError: KL divergence values exceed the specified threshold of 0.002. Max divergence: 0.0020157103426754475
  • Relax it a bit as --max_kl_div=3e-3.

Fix: b/474617159, b/473421624

Tests

Run tests.forward_pass_logit_checker on v6e-256

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@copybara-service copybara-service bot merged commit d4ed226 into main Jan 16, 2026
32 checks passed
@copybara-service copybara-service bot deleted the shuningjin-xlml branch January 16, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants