Skip to content

Fix logical to physical axis mapping for attention heads. - #4607

Open
copybara-service[bot] wants to merge 1 commit into
mainfrom
test_953561420
Open

Fix logical to physical axis mapping for attention heads.#4607
copybara-service[bot] wants to merge 1 commit into
mainfrom
test_953561420

Conversation

@copybara-service

@copybara-service copybara-service Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fix logical to physical axis mapping for attention heads.

Description

Use self._logical_to_mesh_axes to pass logical rules to logical_to_mesh_axes, ensuring the logical axis (e.g. 'tensor') is correctly mapped to the physical mesh axis. This fixes crashes when running with logical sharding configs.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@copybara-service
copybara-service Bot force-pushed the test_953561420 branch 6 times, most recently from d8ae19f to 9c229a2 Compare July 27, 2026 22:15

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'MaxText Test Execution Times'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.15.

Benchmark suite Current: 9daa835 Previous: df95a1f Ratio
Total CPU-TORCH-REFERENCE Tests Duration 288.14900000000006 sec 226.67700000000002 sec 1.27

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant