Add images in SFT loss_func for multimodal post training - #4670
Open
dgouju wants to merge 1 commit into
Open
Conversation
MaxText's post-training wrapper function (use_maxtext_loss_function in train_sft.py) has a hardcoded function signature accepting only text keyword arguments (inputs, targets, etc.), but Tunix's batch iterator unpacks all batch dictionary keys—including images and image_masks—into the loss function during multimodal training.
dgouju
requested review from
RissyRan,
abhinavclemson,
bvandermoon,
gobbleturk,
khatwanimohit and
vipannalla
as code owners
July 29, 2026 16:44
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
dgouju
requested review from
A9isha,
NuojCheng,
SurbhiJainUSC,
aireenmei,
darisoy,
dipannita08,
gagika,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
richjames0,
shralex,
suexu1025 and
xibinliu
as code owners
July 29, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MaxText's post-training wrapper function (use_maxtext_loss_function in train_sft.py) has a hardcoded function signature accepting only text keyword arguments (inputs, targets, etc.), but Tunix's batch iterator unpacks all batch dictionary keys—including images and image_masks—into the loss function during multimodal training.
I was working on post-train Gemma3-4B on Robotic dataset, previously converted from HF LeRobot to Parquet format.
Tests
Tested by post-training Gemma3-4B with the following command:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.