Add 'if typing.TYPE_CHECKING:' export declarations to maxtext/__init__.py and unit test. - #4875
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add 'if typing.TYPE_CHECKING:' export declarations to maxtext/__init__.py and unit test.#4875copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 13, 2026 17:31
…_.py and unit test. 1. Adds 'if typing.TYPE_CHECKING:' block declaring lazily-loaded exports (Sequence, Mesh, pyconfig, MaxTextConfig, models, Transformer, transformer_as_linen, maxtext_utils, model_creation_utils, from_config, from_pretrained). This provides static symbol visibility to linters (Pylint) and typecheckers (Pytype/MyPy) to resolve E0611 (no-name-in-module) while preserving zero-overhead runtime lazy loading. 2. Adds tests/unit/maxtext_init_test.py to verify that 'if TYPE_CHECKING:' imports, __all__, and __getattr__ match cases remain strictly in sync. PiperOrigin-RevId: 963829855
copybara-service
Bot
force-pushed
the
test_963829855
branch
from
August 13, 2026 18:26
35069f0 to
a5c3dc5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'if typing.TYPE_CHECKING:' export declarations to maxtext/init.py and unit test.