Skip to content

pathwaysutils: Remove hostNetwork configuration from PathwaysJobSet pod specifications. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 27, 2026
+4 −12
Merged

pathwaysutils: Remove hostNetwork configuration from PathwaysJobSet pod specifications. #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pathwaysutils/experimental/gke/jobset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,6 @@ def _build_head_job_template(
containers.append(proxy_container)

head_pod_spec = client.V1PodSpec(
host_network=True,
dns_policy="ClusterFirstWithHostNet",
containers=containers,
restart_policy="Never",
)
Expand Down Expand Up @@ -466,8 +464,6 @@ def _build_worker_job_template(
),
)
],
host_network=True,
dns_policy="ClusterFirstWithHostNet",
restart_policy="OnFailure",
)
if termination_grace_period_seconds is not None:
Expand Down
8 changes: 4 additions & 4 deletions pathwaysutils/test/experimental/gke/jobset_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ def test_headless_head_job_pod_spec(self):
self.assertIn("pathways-head", helper.jobs)
self.assertEqual(helper.jobs["pathways-head"]["replicas"], 1)
pod_spec = helper.pod_specs["pathways-head"]
self.assertTrue(pod_spec["hostNetwork"])
self.assertEqual(pod_spec["dnsPolicy"], "ClusterFirstWithHostNet")
self.assertNotIn("hostNetwork", pod_spec)
self.assertNotIn("dnsPolicy", pod_spec)
self.assertEqual(pod_spec["restartPolicy"], "Never")

def test_headless_head_job_containers(self):
Expand Down Expand Up @@ -207,8 +207,8 @@ def test_worker_job_pod_spec(self):
helper = JobSetManifestHelper(config)

pod_spec = helper.pod_specs["pathways-worker"]
self.assertTrue(pod_spec["hostNetwork"])
self.assertEqual(pod_spec["dnsPolicy"], "ClusterFirstWithHostNet")
self.assertNotIn("hostNetwork", pod_spec)
self.assertNotIn("dnsPolicy", pod_spec)
self.assertEqual(pod_spec["restartPolicy"], "OnFailure")
self.assertEqual(pod_spec["terminationGracePeriodSeconds"], 60)

Expand Down
4 changes: 0 additions & 4 deletions pathwaysutils/test/experimental/gke/testdata/model_lite_tpuv5e_4x8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ spec:
volumeMounts:
- mountPath: /tmp
name: shared-tmp
dnsPolicy: ClusterFirstWithHostNet
hostNetwork: true
initContainers:
- args:
- --server_port=29001
Expand Down Expand Up @@ -209,8 +207,6 @@ spec:
volumeMounts:
- mountPath: /tmp
name: shared-tmp
dnsPolicy: ClusterFirstWithHostNet
hostNetwork: true
nodeSelector:
cloud.google.com/gke-tpu-accelerator: tpu-v5-lite-podslice
cloud.google.com/gke-tpu-topology: 4x8
Expand Down
Loading