Propagate CMake dependency for opengl/x11#2752
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Jan 21, 2026
Merged
Propagate CMake dependency for opengl/x11#2752jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Member
|
This looks very promising, thanks @qbisi, and I'd love to get feedback from @spiffmon, @JGamache-autodesk, and other domain experts before merging it. |
Contributor
Author
|
Thanks for quick responding, updated the last commit (find opengl should be in scope unix and not macos). |
jstone-lucasfilm
approved these changes
Jan 21, 2026
Member
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @qbisi!
b20f54c
into
AcademySoftwareFoundation:main
33 checks passed
Contributor
Author
|
Hi, any plan to make a new release in 2026. I would like to make a pr to downstream openusd that make use of the finding MaterialXRenderHw component. |
Member
|
@qbisi Yes, we're in the process of organizing a MaterialX v1.39.5 release, and we'll send out announcements once the first release candidate is available. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pr aims to fix cmake configure error of vtk-9.6.0 when building with openusd with materialx.
In nixpkgs, the cmake configure system will complain
also the target OpenGL::OpenGL X11::Xt is required to link with other MaterialX target.
So, i believe MaterialX need to propagate dependency OpenGL/libX11/libXt for downstream project to link with.
Note, in the last commit, i propagate OpenGL dependency conditionally as only the target MaterialXRenderGlsl link publicly with OpenGL, so i propagate OpenaGl optionally when downstream project require the component RenderGlsl explicitly (e.g. openusd might need this), tell me if you want this to be unconditionally propagated.
resolve #2421.
cc @spiffmon