Skip to content

Change JDK version to 21 and distribution to adopt#1721

Merged
gcatanese merged 1 commit intomainfrom
fix/jdk-format-action
Feb 9, 2026
Merged

Change JDK version to 21 and distribution to adopt#1721
gcatanese merged 1 commit intomainfrom
fix/jdk-format-action

Conversation

@gcatanese
Copy link
Contributor

PR #1718 has updated the version of the spotless-maven-plugin, which now requires JDK 21+

This PR updates the JDK version used by format action.yml, aligning with the configuration used already in .github/workflows/javaci.yml

Updated JDK version and distribution for formatting action.
@gcatanese gcatanese requested review from a team as code owners February 9, 2026 14:28
@gcatanese gcatanese added the Fix Indicates a bug fix label Feb 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Java Development Kit (JDK) configuration within the GitHub Actions format workflow. The primary goal is to ensure compatibility with the latest version of the spotless-maven-plugin, which now mandates JDK 21. This change also standardizes the JDK distribution used across the project's CI/CD setup, promoting consistency and preventing potential build failures related to environment mismatches.

Highlights

  • JDK Version Update: The java-version used in the .github/actions/format/action.yml workflow has been upgraded from 11 to 21.
  • JDK Distribution Change: The distribution for the JDK setup in the format action has been switched from temurin to adopt.
  • Dependency Alignment: These changes are necessary to accommodate the updated spotless-maven-plugin, which now requires JDK 21+, and to align the format action with the existing configuration in .github/workflows/javaci.yml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/actions/format/action.yml
    • Updated java-version from 11 to 21.
    • Changed distribution from temurin to adopt.
    • Renamed the step 'Set up JDK 11 for formatting' to 'Set up JDK for formatting' for generality.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JDK version to 21 in the format action, which is required by a newer version of the spotless-maven-plugin. The change is straightforward, but I've noticed that the Java distribution has been changed to 'adopt', which is deprecated for the actions/setup-java action. I've left a comment suggesting to revert this to 'temurin' to ensure the long-term stability of the workflow.

distribution: 'temurin'

java-version: '21'
distribution: 'adopt'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The adopt distribution for actions/setup-java is deprecated and will be removed in a future version. It is recommended to use temurin instead, which was the value used previously. Using a deprecated value could cause this action to fail in the future.

        distribution: 'temurin'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will create a new issue for addressing this

@gcatanese gcatanese added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit e75033a Feb 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Indicates a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants