Add ITS stuck-pixel CCDB object output#15468
Open
JaehyeokRyu wants to merge 2 commits into
Open
Conversation
JaehyeokRyu
requested review from
fprino,
mconcas,
mcoquet642 and
shahor02
as code owners
shahor02
requested changes
Jun 2, 2026
|
|
||
| // Flag to avoid that endOfStream and stop are both done | ||
| bool isEnded = false; | ||
| <<<<<<< HEAD |
Collaborator
There was a problem hiding this comment.
There are failed merge remnants to remove.
Author
There was a problem hiding this comment.
Thanks for the comment. Fixed, the leftover conflict marker has been removed.
Collaborator
|
Thanks, could you also fix the formatting problems? |
f3sch
reviewed
Jun 4, 2026
| #pragma link C++ class o2::itsmft::Digit + ; | ||
| #pragma link C++ class o2::itsmft::NoiseMap + ; | ||
| #pragma link C++ class o2::itsmft::TimeDeadMap + ; | ||
| #pragma link C++ class o2::itsmft::StuckPixelData + ; |
Collaborator
There was a problem hiding this comment.
Should not also the StuckPixelEntry be serialized or does this just work since it is a pod? Anyways since you declare the ClassDef maybe add:
Suggested change
| #pragma link C++ class o2::itsmft::StuckPixelData + ; | |
| #pragma link C++ class o2::itsmft::StuckPixelEntry + ; | |
| #pragma link C++ class o2::itsmft::StuckPixelData + ; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an ITS-only StuckPixels CCDB payload to the ITSMFT dead-map builder workflow.
Main changes:
The existing TimeDeadMap behavior is kept unchanged.