-
Notifications
You must be signed in to change notification settings - Fork 24
OCTRL-1021 Add package documentation for all Go packages #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
fa8f16a
fa0f839
e09e45d
057c96a
9a2a33f
7bfb4cc
bab019d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| // Package remote implements a remote gRPC client backend for the configuration | ||
| // service, providing access to remote configuration stores. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Remote" meaning basically that is handled by a different application. Please clarify this.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarified that "remote" means handled by a different application. Updated to: "Package remote implements a remote configuration backend for the configuration service, accessing configuration handled by a different application via gRPC." (7bfb4cc) |
||
| package remote | ||
|
|
||
| import ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| // Package topic defines topic constants and types for the event system, | ||
| // providing structured topic names for different event types. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Masło maślane. Shorten it to avoid repetition.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shortened to avoid repetition: "Package topic defines constants and types for event system topics." (7bfb4cc) |
||
| package topic | ||
|
|
||
| type Topic string | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| // Package event provides event publishing and streaming functionality for | ||
| // O² Control components, supporting both Kafka and in-memory event systems. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you point me to the in-memory event system you mentioned here?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right - the "in-memory event system" was inaccurate. The DummyWriter is actually a no-op writer, not a true in-memory system. Updated to: "Package event provides event publishing and streaming functionality for O² Control components, supporting Kafka and dummy event writers." (7bfb4cc) |
||
| package event | ||
|
|
||
| import ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| // Package monitoring provides monitoring and metrics collection functionality, | ||
| // including HTTP endpoints for health checks and metrics publishing. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you point me to the health check endpoint?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're correct - there are no HTTP health check endpoints in this package (the health endpoints are gRPC-based in core/server.go). Simplified the description to: "Package monitoring provides monitoring and metrics collection functionality for O² Control components." (7bfb4cc) |
||
| package monitoring | ||
|
|
||
| import ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |||||||
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||||||||
| */ | ||||||||
|
|
||||||||
| // Package uid provides unique identifier generation functionality, | ||||||||
| // including machine-specific and time-based ID generation utilities. | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplified as suggested: "Package uid provides unique identifier generation functionality." (7bfb4cc) |
||||||||
| package uid | ||||||||
|
|
||||||||
| import ( | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| // Package core implements the main AliECS core functionality including | ||
| // the gRPC API server, environment management, and integration with various services. | ||
| package core | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you add the package description here instead of core/core.go? Whenever there is a source file with the same name as the package name, please add the package description there. Review all the changes in this regards.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved the package description from config.go to core.go since core.go has the same name as the package. Also reviewed and moved package documentation for all integration packages to their respective plugin.go files. (7bfb4cc) |
||
|
|
||
| import ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| // Package bookkeeping provides integration with the ALICE Bookkeeping system | ||
| // for tracking runs and retrieving LHC fill information. | ||
| package bookkeeping | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for plugin packages, put the package descriptions in
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved package descriptions to plugin.go files for all integration packages: bookkeeping, dcs, odc, ddsched, and trg. (7bfb4cc) |
||
|
|
||
| import ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |||||||
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||||||||
| */ | ||||||||
|
|
||||||||
| // Package trg provides integration with the ALICE trigger system | ||||||||
| // for managing trigger configurations and run coordination. | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplified as suggested: "Package trg provides integration with the ALICE trigger system." (7bfb4cc) |
||||||||
| package trg | ||||||||
|
|
||||||||
| import ( | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |||||||||
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||||||||||
| */ | ||||||||||
|
|
||||||||||
| // Package taskclass provides task class definitions and resource management | ||||||||||
| // for different types of tasks in the O² Control system. | ||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated as suggested: "Package taskclass provides task class definitions and resource management for different types of tasks." (7bfb4cc) |
||||||||||
| package taskclass | ||||||||||
|
|
||||||||||
| import "strconv" | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessarily file-based, different cfgbackends can be used, yaml is only one of them. The locality here means that here we have direct access to the backend, while remote/service.go has gRPC in between. I could be wrong though, so verify my words.
Rewrite the package description accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the description to clarify that "local" means direct access to the backend (not necessarily file-based) while "remote" has gRPC in between. Changed to: "Package local implements a local configuration backend for the configuration service, providing direct access to the backend storage without gRPC." (7bfb4cc)