Skip to content

[PWGLF] Omegahm: downscaling HBs (pileup study)#15372

Merged
romainschotter merged 7 commits intoAliceO2Group:masterfrom
lietava:omegahm
Mar 14, 2026
Merged

[PWGLF] Omegahm: downscaling HBs (pileup study)#15372
romainschotter merged 7 commits intoAliceO2Group:masterfrom
lietava:omegahm

Conversation

@lietava
Copy link
Collaborator

@lietava lietava commented Mar 13, 2026

Downscaling HBs instead of collisions

@github-actions github-actions bot added the pwglf label Mar 13, 2026
@github-actions github-actions bot changed the title Omegahm: downscaling HBs (pileup study) [PWGLF] Omegahm: downscaling HBs (pileup study) Mar 13, 2026
romainschotter
romainschotter previously approved these changes Mar 13, 2026
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Mar 13, 2026

Error while checking build/O2Physics/o2 for 6256e35 at 2026-03-13 13:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15372-slc9_x86-64/0/PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1005:18: error: unused variable 'ts' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Mar 13, 2026
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include what you use.

PWGLF/Tasks/Strangeness/nonPromptCascade.cxx Outdated
Copy link
Collaborator

@vkucera vkucera Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this. It prevents the automatic sorting.

Copy link
Collaborator Author

@lietava lietava Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Collaborator

@vkucera vkucera Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please either push your updates only when you address all of the known issues or convert the PR to a draft and mark it as ready for review when all issues are addressed. Otherwise you just keep triggering useless recompilations.

Copy link
Collaborator Author

@lietava lietava Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I was trying to address all known issues at once, sorry. Now I am not aware of any issues.

Copy link
Collaborator

@vkucera vkucera Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are still missing some header includes. See my first comment.

Copy link
Collaborator Author

@lietava lietava Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean this "Please include what you use." ? If so, please, explain what should I include. Thanks.

Copy link
Collaborator

@vkucera vkucera Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is explained in the error messages of the failing MegaLinter check. Please check. Thanks

Copy link
Collaborator Author

@lietava lietava Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry. I was fully ignoring MegaLinter. Now should be ok.

@vkucera vkucera marked this pull request as draft March 13, 2026 13:32
@lietava lietava marked this pull request as ready for review March 14, 2026 07:20
@lietava lietava marked this pull request as draft March 14, 2026 13:18
@lietava lietava marked this pull request as ready for review March 14, 2026 13:35
@romainschotter romainschotter self-requested a review March 14, 2026 15:55
@romainschotter romainschotter merged commit 02b5816 into AliceO2Group:master Mar 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@romainschotter romainschotter romainschotter approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lietava @alibuild @vkucera @romainschotter