Skip to content

[PWGLF] heavyionmultiplicity.cxx#17002

Open
murioni wants to merge 1 commit into
AliceO2Group:masterfrom
murioni:murioni-patch-1
Open

[PWGLF] heavyionmultiplicity.cxx#17002
murioni wants to merge 1 commit into
AliceO2Group:masterfrom
murioni:murioni-patch-1

Conversation

@murioni

@murioni murioni commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

fixing small error

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 5 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for cb1c259 at 2026-07-10 11:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 12 warnings.'
Found 30 errors and 12 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/0f4835ac5820cd1d5378e44a4f661a59b811ff33/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:21:1: error: included header TrackSelection.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:22:1: error: included header TrackSelectionDefaults.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:71:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:79:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:87:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:101:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:111:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:136:10: error: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:137:10: error: variable 'axisVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:138:10: error: variable 'axisEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:139:10: error: variable 'axisEtaExtended' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:140:10: error: variable 'axisPhi' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:141:10: error: variable 'axisPhi2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:142:10: error: variable 'axisTrackType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:143:10: error: variable 'axisGenPtVary' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:144:10: error: variable 'axisSpecies' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:145:10: error: variable 'axisGenTrkType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:146:10: error: variable 'axisRecTrkType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:147:10: error: variable 'axisMassK0s' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:148:10: error: variable 'axisMassLambda' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:149:10: error: variable 'axisTracks' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:150:10: error: variable 'axisDeltaEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:155:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:670:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:672:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:794:15: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:881:23: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:918:9: error: do not use 'else' after 'continue' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:978:17: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:979:17: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/0f4835ac5820cd1d5378e44a4f661a59b811ff33/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:509:85: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:511:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:562:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:585:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:588:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:669:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:671:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1090:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1093:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/heavyionMultiplicity.cxx:1096:46: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants