[PWGLF] cha01710analysis.cxx: initial commit on charged a0(1710) - #17292
Merged
Conversation
jikim1290
requested review from
alibuild,
dmallick2,
jaelpark,
lauraser,
mpuccio,
omvazque,
prottayCMT,
shouqiye,
skundu692,
smaff92,
victor-gonzalez and
wenyaCern
as code owners
August 3, 2026 06:34
|
O2 linter results: ❌ 2 errors, |
jikim1290
added a commit
to jikim1290/O2Physics
that referenced
this pull request
Aug 3, 2026
Please consider the following formatting changes to AliceO2Group#17292
Collaborator
|
Error while checking build/O2Physics/code-check for 52bc46b at 2026-08-03 09:57: Full log here. |
jikim1290
added a commit
to jikim1290/O2Physics
that referenced
this pull request
Aug 3, 2026
Please consider the following formatting changes to AliceO2Group#17292
jikim1290
added a commit
to jikim1290/O2Physics
that referenced
this pull request
Aug 3, 2026
Please consider the following formatting changes to AliceO2Group#17292
Collaborator
|
Error while checking build/O2Physics/code-check for 1b6f9de at 2026-08-03 15:39: Full log here. |
jikim1290
added a commit
to jikim1290/O2Physics
that referenced
this pull request
Aug 3, 2026
Please consider the following formatting changes to AliceO2Group#17292
Collaborator
|
Error while checking build/O2Physics/code-check for 4b06969 at 2026-08-03 15:59: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for dfdb355 at 2026-08-03 18:09: Full log here. |
Please consider the following formatting changes to AliceO2Group#17292
dmallick2
approved these changes
Aug 4, 2026
dmallick2
enabled auto-merge (squash)
August 4, 2026 07:13
Collaborator
|
@dmallick2 You are supposed to merge PRs only when they pass all tests. This PR introduces new errors and you did not even wait for the code-check result. Please pay attention to the CI. |
vkucera
reviewed
Aug 4, 2026
| kSideband | ||
| }; | ||
|
|
||
| TRandom* rn = new TRandom(); |
Collaborator
There was a problem hiding this comment.
You are responsible for managing the memory you allocate.
- Why do you need dynamic allocation here?
- Where do you destroy the object?
Comment on lines
+53
to
+62
| enum CentSel { | ||
| kFT0C = 0, | ||
| kFT0M | ||
| }; | ||
|
|
||
| enum V0MassRegion { | ||
| kReject = 0, | ||
| kSignal, | ||
| kSideband | ||
| }; |
Collaborator
There was a problem hiding this comment.
Follow the O2 naming conventions. This is not ROOT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial commit on charged a0(1710)