[PWGCF] Change nsigma TOF selections to optional cuts, force bit=1 when no TOF is found - #17315
Open
allesgrau wants to merge 9 commits into
Open
[PWGCF] Change nsigma TOF selections to optional cuts, force bit=1 when no TOF is found#17315allesgrau wants to merge 9 commits into
allesgrau wants to merge 9 commits into
Conversation
Please consider the following formatting changes to AliceO2Group#17302
allesgrau
requested review from
alibuild,
ariedel-cern,
dimihayl,
lauraser,
shouqiye,
victor-gonzalez and
wrzesaCERN
as code owners
August 4, 2026 12:26
|
O2 linter results: ❌ 0 errors, |
ariedel-cern
reviewed
Aug 4, 2026
| o2::framework::Configurable<std::vector<float>> posDauTof{"posDauTof", {}, "Maximum |nsimga_Pion/Proton| TOF for positive daughter tracks"}; \ | ||
| o2::framework::Configurable<std::vector<float>> negDauTof{"negDauTof", {}, "Maximum |nsigma_Pion/Proton| TOF for negative daughter tracks"}; | ||
| o2::framework::Configurable<std::vector<float>> negDauTof{"negDauTof", {}, "Maximum |nsigma_Pion/Proton| TOF for negative daughter tracks"}; \ | ||
| o2::framework::Configurable<bool> requireTof{"requireTof", false, "If true, only keep candidates whose daughters have a TOF signal"}; |
Collaborator
There was a problem hiding this comment.
I would introduce 2 new configurables
- The first one you have, i.e. making TOF a minimal (true) or optional (false) selection
- The second configurable should be called like "keepTracksWithoutTof", such that daughters without TOF can be kept
ariedel-cern
reviewed
Aug 4, 2026
| mOmegaMassUpperLimit = filter.rejectMassOmegaMax.value; | ||
| this->addSelection(kBachelorTpcPion, cascadeSelectionNames.at(kBachelorTpcPion), config.bachelorTpcPion.value, limits::kAbsUpperLimit, true, true, false); | ||
| this->addSelection(kBachelorTofPion, cascadeSelectionNames.at(kBachelorTofPion), config.bachelorTofPion.value, limits::kAbsUpperLimit, true, true, false); | ||
| this->addSelection(kBachelorTofPion, cascadeSelectionNames.at(kBachelorTofPion), config.bachelorTofPion.value, limits::kAbsUpperLimit, true, false, false); |
Collaborator
There was a problem hiding this comment.
Here the flag should be set according to "requireTof" from the configuration
ariedel-cern
reviewed
Aug 4, 2026
| mXiMassUpperLimit = filter.rejectMassXiMax.value; | ||
| this->addSelection(kBachelorTpcKaon, cascadeSelectionNames.at(kBachelorTpcKaon), config.bachelorTpcKaon.value, limits::kAbsUpperLimit, true, true, false); | ||
| this->addSelection(kBachelorTofKaon, cascadeSelectionNames.at(kBachelorTofKaon), config.bachelorTofKaon.value, limits::kAbsUpperLimit, true, true, false); | ||
| this->addSelection(kBachelorTofKaon, cascadeSelectionNames.at(kBachelorTofKaon), config.bachelorTofKaon.value, limits::kAbsUpperLimit, true, false, false); |
| if (bachelor.hasTOF()) { | ||
| this->evaluateObservable(kBachelorTofPion, bachelor.tofNSigmaPi()); | ||
| this->evaluateObservable(kBachelorTofKaon, bachelor.tofNSigmaKa()); | ||
| } else if (!mRequireTof) { |
Collaborator
There was a problem hiding this comment.
here you should then check against the flag whether to keep tracks without Tof or not
Also, the limit to check against should be 0 (since it is a AbsUpperCut, so the only value which should alwasy succeed is 0. Using max value would always fail)
Collaborator
|
Hi @allesgrau , |
Please consider the following formatting changes to AliceO2Group#17315
Collaborator
ariedel-cern
reviewed
Aug 5, 2026
| #include <array> | ||
| #include <cmath> | ||
| #include <cstdint> | ||
| #include <limits> |
Collaborator
There was a problem hiding this comment.
This include is no longer needed. Same in V0Builder
ariedel-cern
reviewed
Aug 5, 2026
| this->evaluateObservable(kBachelorTofPion, bachelor.tofNSigmaPi()); | ||
| this->evaluateObservable(kBachelorTofKaon, bachelor.tofNSigmaKa()); | ||
| } else if (mKeepTracksWithoutTof) { | ||
| this->setBitmask(kBachelorTofPion, 0); |
Collaborator
There was a problem hiding this comment.
This call would set the bitmask itself to 0, i.e. the selection would not be passed, which is what we want to avoid in this branch if the track has no TOF.
You have to call here
this->evaluateObservable(kBachelorTofPion, 0);
Like this we compare 0 against all the limits (which are positive definite), so all bits in the bitmask will be set to 1.
This applies to all other calls below (and in the V0Builder).
ariedel-cern
requested changes
Aug 5, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.