Skip to content

[PWGLF] Add closure-test correlations for truth triggers with reconstructed-track matches in hStrangeCorrelation.cxx - #17350

Open
kcui1 wants to merge 1 commit into
AliceO2Group:masterfrom
kcui1:MCIDtrue
Open

[PWGLF] Add closure-test correlations for truth triggers with reconstructed-track matches in hStrangeCorrelation.cxx#17350
kcui1 wants to merge 1 commit into
AliceO2Group:masterfrom
kcui1:MCIDtrue

Conversation

@kcui1

@kcui1 kcui1 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Adds optional closure-test correlation histograms requiring only the truth trigger to have at least one reconstructed track with a matching MC label, while leaving the associated truth particles and original closure-test selection unchanged.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add closure-test correlations for truth triggers with reconstructed-track matches in hStrangeCorrelation.cxx [PWGLF] Add closure-test correlations for truth triggers with reconstructed-track matches in hStrangeCorrelation.cxx Aug 5, 2026
@romainschotter
romainschotter enabled auto-merge (squash) August 5, 2026 17:10
@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d33e48b at 2026-08-05 19:51:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 30 errors and 0 warnings.'
Found 30 errors and 0 warnings.
++ [[ 30 -gt 0 ]]
++ cat /sw/BUILD/ced84f0ea7e025449847d13f4b6a09d692a80519/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:95:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:583:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:959:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2603:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2781:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2884:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3035:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3190:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3275:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3332:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3391:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3441:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3544:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3574:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3739:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3753:11: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3786:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3832:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3833:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3834:30: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3888:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3901:26: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3912:28: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4245:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4252:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4310:110: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4376:140: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4532:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4562:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Utils/inelGt.h:117:11: error: using integer absolute value function 'abs' when argument is of floating point type [clang-diagnostic-absolute-value,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 30 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants