-
Notifications
You must be signed in to change notification settings - Fork 11
Antalya 25.8 Backport of #79012, #87735 and #88827 - Enable parquet reader v3 by default #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Settings to write and verify parquet checksums
A few more parquet fixes
Enable parquet reader v3 by default
The version from the upstream contains changes specific to ClickHouse 25.10+, which are not applicable to our build.
With the backport of 88827, prewhere for datalakes was explicitly disabled.
|
Test failures look unrelated to the PR |
arthurpassos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared the three referenced PRs with this one and things look sane. LGTM
|
The failures look mostly unrelated to the changes. For the record, the log of the test states the following: |
|
I don't like it that integration tests flaky check times out for the 4th time But I guess it has nothing to do with this PR actually |
This PR is a combination of backporting three upstream PRs:
It also reverts #1171 that partially backported ClickHouse#88827 in favour of properly backporting it.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Parquet reader v3 is enabled by default (ClickHouse#79012, ClickHouse#87735 and ClickHouse#88827 by @al13n321)
CI/CD Options
Exclude tests:
Regression jobs to run: