Antalya 26.1 : Fix Alter table operations(add, modify, drop, rename) support for Iceberg#1594
Open
subkanthi wants to merge 8 commits intoantalya-26.1from
Open
Antalya 26.1 : Fix Alter table operations(add, modify, drop, rename) support for Iceberg#1594subkanthi wants to merge 8 commits intoantalya-26.1from
subkanthi wants to merge 8 commits intoantalya-26.1from
Conversation
27 tasks
subkanthi
changed the title
Collaborator
Author
|
Collaborator
Author
subkanthi
changed the title
…d columns to a separate function, added unit tests
subkanthi
changed the title
subkanthi
commented
Apr 2, 2026
|
|
||
| void assertInitializedDL() const | ||
| { | ||
| BaseStorageConfiguration::assertInitialized(); |
Collaborator
Author
There was a problem hiding this comment.
This was removed in upstream
Collaborator
Author
|
Testing: |
Collaborator
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f344d72b29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+215
to
+217
| Poco::JSON::Array::Ptr identifier_fields = new Poco::JSON::Array; | ||
| schema_for_rest->set("identifier-field-ids", identifier_fields); | ||
| } |
There was a problem hiding this comment.
Overwriting identifier-field-ids with an empty array discards any existing row identity configuration for tables created outside ClickHouse. In buildUpdateMetadataRequestBody, schema_for_rest is cloned from the new schema but then unconditionally reset, so an ALTER against a REST-catalog Iceberg table with non-empty identifier fields will silently clear them in the committed schema update. This can break downstream equality-delete/merge workflows that depend on those IDs.
Useful? React with 👍 / 👎.
Comment on lines
+756
to
+760
| if (!catalog->updateMetadata(namespace_name, table_name, catalog_filename, metadata)) | ||
| { | ||
| LOG_WARNING(log, "Iceberg alter: catalog update failed for '{}'", catalog_filename); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
After successfully writing the new metadata file, a catalog commit failure currently does continue, which re-enters the loop and applies the same alter operation again on top of already-updated metadata. For ADD COLUMN, this path can produce duplicate field entries (the add generator does not guard against existing names), and for other operations it can cause spurious failures because the first write already changed the schema version. This failure mode is triggered whenever updateMetadata returns false after a successful metadata write (e.g., transient REST error).
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixes Alter table ADD/DROP/RENAME/MODIFY column for Iceberg tables.
Documentation entry for user-facing changes
Solved ClickHouse#86024.
Fixed logic of updating metadata JSON as per Iceberg REST API Spec.
Added unit/integration tests.
CI/CD Options
Exclude tests:
Regression jobs to run: