feat(datetime): adding some tests#64
Open
SuperFola wants to merge 6 commits into
Open
Conversation
SuperFola
commented
May 30, 2026
| # @param _tz String, time zone name | ||
| # @author https://github.com/SuperFola | ||
| (let timezoneOffset (fun (_tz) { | ||
| (let timezoneOffset (dict:get timezoneOffsets _tz)) |
Member
Author
There was a problem hiding this comment.
Need to rename the var to avoid shadowing here
| # =end | ||
| # @author https://github.com/SuperFola | ||
| (let makeUTCTimestamp (fun (_year (mut _month) _day _hour _minute _second _millisecond _tz _dst?) { | ||
| # _month is between 1 and 12, this algorithm needs it between 0 and 11 |
Member
Author
There was a problem hiding this comment.
Add asserts for month, year, day, hour minutes and seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40