chore: enhance comment for extract_lane functions to include "idx" argument needs to be compile time constant#2890
Merged
HerrCai0907 merged 7 commits intoAssemblyScript:mainfrom Dec 12, 2024
Conversation
…idx argument needs to be compile time constant - issue AssemblyScript#2877
Contributor
Author
|
HerrCai0907
reviewed
Dec 11, 2024
Member
HerrCai0907
left a comment
HerrCai0907
left a comment
There was a problem hiding this comment.
please revert change of notices.
maybe also add this comment to replace_lane
…include idx argument needs to be compile time constant - issue AssemblyScript#2877" This reverts commit 509ffc4.
This reverts commit dd981cf.
…ions to include idx argument needs to be compile time constant - issue AssemblyScript#2877"" This reverts commit 62425c3.
… to be compile time constant. - AssemblyScript#2877
Member
|
sorry. maybe there are some mistake, your name still need to be added in notice, but please don't change the format. |
Contributor
Author
done, not sure how I got it all messed up the first time. Sorry about that. |
HerrCai0907
changed the title
HerrCai0907
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2877
Changes proposed in this pull request:
⯈ Changes made in the TypeScript declaration file
std/assembly/index.d.ts, where the v128.extract_lane functions are declared.⯈ Comments now include:
idx argument needs to be compile time constant.⯈