Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the check_spdx script to simplify its functionality by removing the ability to automatically add SPDX headers to files, making it a check-only tool.
- Removes the
add_spdx_header()function and associated automatic header addition functionality - Removes command-line argument parsing for the
--check-onlyflag - Simplifies the main function to only check for SPDX headers without modification capabilities
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/moldflow/boundary_conditions.py | Removes SPDX header from the file |
| scripts/check_spdx.py | Removes automatic SPDX header addition functionality, making it check-only |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot what should be done about this PR to move it forward? |
|
@copilot please intelligently resolve the merge conflicts in this PR |
Description
check_spdx.pyscript to fail the CI if the headers are missing.Type of change
Please delete options that are not relevant.
Checklist
Please delete options that are not relevant.
Testing
N/A
Additional Notes
N/A