feat: default counter value #19954
Open
feat: default counter value #19954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deffrian
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
alexghr
reviewed
Jan 27, 2026
Contributor
alexghr
left a comment
alexghr
left a comment
There was a problem hiding this comment.
This is a great idea but it needs a different way of initializing counters to 0
Comment on lines
24
to
29
| defaultValue: number | undefined = 0, | ||
| ): UpDownCounter { | ||
| const counter = meter.createUpDownCounter(metric); | ||
| if (defaultValue !== undefined) { | ||
| counter.add(defaultValue); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think this way of passing a default will work. JS can't differentiate between a missing parameter and an explicit undefined
> function test(a = "foo") { console.log(a) }
> test()
foo
> test(undefined)
foo
> test(0)
0
56c636f to
f17d7f2
Compare
attributes more attributes
deffrian
force-pushed
the
nikita/default-counter
branch
from
f17d7f2 to
72d0fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: A-414
All counters that are reported with attributes are not set to zero