refactor!: contract logging plumbing cleanup#20282
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
02-09-refactor_contract_logging_plumbing_cleanup
branch
2 times, most recently
from
f5b3b8a to
b0b3c1c
Compare
AztecBot
force-pushed
the
01-27-feat_separate_contract_log_channel
branch
from
47f99c2 to
166c4d6
Compare
Base automatically changed from
01-27-feat_separate_contract_log_channel
to
next
February 9, 2026 18:20
benesjan
force-pushed
the
02-09-refactor_contract_logging_plumbing_cleanup
branch
from
b0b3c1c to
4bf1c81
Compare
benesjan
changed the base branch from
graphite-base/20282
to
02-10-fix_post-noir-sync_cleanup
benesjan
force-pushed
the
02-09-refactor_contract_logging_plumbing_cleanup
branch
from
ce99975 to
4c010c7
Compare
benesjan
requested review from
a team,
LeilaWang,
dbanks12,
fcarreiro and
sirasistant
as code owners
benesjan
changed the title
benesjan
added
the
ci-no-fail-fast
Collaborator
Compile (Noir contracts)TypeScript validationAction required: Please fix the docs examples or update them to match the current API. cc @AztecProtocol/devrel |
benesjan
commented
Feb 10, 2026
| "avmOpcodeStorageRead" => handle_storage_read(avm_instrs, destinations, inputs), | ||
| "avmOpcodeStorageWrite" => handle_storage_write(avm_instrs, destinations, inputs), | ||
| "utilityDebugLog" => handle_debug_log(avm_instrs, destinations, inputs), | ||
| "utilityLog" => handle_debug_log(avm_instrs, destinations, inputs), |
Contributor
Author
There was a problem hiding this comment.
Talked with Alvaro in DMs and he said that stopping in the transpiler when it comes to the public domain is the way to go.
Contributor
There was a problem hiding this comment.
As a general concern with this PR, I'm a bit worried about the potential confusion between "aztec logs" and logging infrastructure. Do you think maybe using logging as much as possible for the latter case would help disambiguate?
In the case of this particular change this would mean utilityLog => utilityLogging (I guess I'm seeing why it was called utilityDebugLog in the first place...)
Contributor
There was a problem hiding this comment.
never mind my comment, after going through the whole PR I think it's all quite clear now
Contributor
Author
There was a problem hiding this comment.
I'm a bit worried about the potential confusion between "aztec logs" and logging infrastructure.
I share your concern but don't like utilityLogging as it doesn't communicate and action and I failed to come up with a better naming 😏
mverzilli
approved these changes
Feb 11, 2026
benesjan
force-pushed
the
02-09-refactor_contract_logging_plumbing_cleanup
branch
from
d9c11ca to
55e3058
Compare
AztecBot
force-pushed
the
02-09-refactor_contract_logging_plumbing_cleanup
branch
from
55e3058 to
25002e4
Compare
The `debug_log` naming became problematic as different log levels are supported and hence the name collides with the debug log level even though it's a generic util. For this reason I've renamed `debug_log` simply as `log` and I've cleaned up what used to be `debug_log.nr` file (in this PR renamed to `logging.nr`). The cleanup consists of: - dropping the log_slice functions (use of slices is now discouraged), - introducing individual functions for different log levels, - un-exposing the log level constants (the specific functions should be used instead) This is a breaking change as the imports need to get updated. This PR is a followup of #19960
AztecBot
force-pushed
the
02-09-refactor_contract_logging_plumbing_cleanup
branch
from
25002e4 to
3fcb658
Compare
benesjan
deleted the
02-09-refactor_contract_logging_plumbing_cleanup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
debug_lognaming became problematic as different log levels are supported and hence the name collides with the debug log level even though it's a generic util.For this reason I've renamed
debug_logsimply aslogand I've cleaned up what used to bedebug_log.nrfile (in this PR renamed tologging.nr). The cleanup consists of:This is a breaking change as the imports need to get updated.
This PR is a followup of #19960