Open
Conversation
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
from
d4264ee to
a04ef40
Compare
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
2 times, most recently
from
ac433fa to
b9903c5
Compare
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
deffrian
force-pushed
the
nikita/n-tps-zero-metrics
branch
from
29b8e0d to
cdbe63b
Compare
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
deffrian
added
the
ci-network-bench
AztecBot
removed
the
ci-network-bench
mralj
approved these changes
Feb 23, 2026
Contributor
mralj
left a comment
mralj
left a comment
There was a problem hiding this comment.
Pre-approving, I have only small nitpicks about naming
| } | ||
| } | ||
|
|
||
| public objectAdded(key: bigint | string): void { |
Contributor
There was a problem hiding this comment.
I don't like naming of this - it's to vague
| this.txAddedTimestamp.set(key, Date.now()); | ||
| } | ||
|
|
||
| public objectRemoved(key: bigint | string): void { |
Contributor
There was a problem hiding this comment.
Similar to above, naming is too vague
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: A-493
Updated dashboard:
https://aztecprotocol.github.io/benchmark-page-data/bench/?branch=pr-20656
peerCountmetric into total connections and healthy connectionspeerConnectedAtmap entries are now deleted after recording connection durationTxPoolV2