Skip to content

fix: handle error types serialization errors#22379

Open
spalladino wants to merge 1 commit intomerge-train/spartanfrom
spl/handle-err-format-err
Open

fix: handle error types serialization errors#22379
spalladino wants to merge 1 commit intomerge-train/spartanfrom
spl/handle-err-format-err

Conversation

@spalladino
Copy link
Copy Markdown
Contributor

Do not throw in the logger when we try to log something that fails during serialization.

I ran into this while playing with a test script:

TypeError: Cannot read properties of undefined (reading 'value')                                         
    at formatProperty (node:internal/util/inspect:2280:12)                                               
    at formatRaw (node:internal/util/inspect:1176:9)                                                     
    at formatValue (node:internal/util/inspect:932:10)                                                   
    at inspect (node:internal/util/inspect:409:10)                                                       
    at formatErr                                                                                         
(file:///home/santiago/Projects/aztec-3/yarn-project/foundation/dest/log/pino-logger.js:326:29)          
    at Object.error                                                                                      
(file:///home/santiago/Projects/aztec-3/yarn-project/foundation/dest/log/pino-logger.js:56:97)           
    at L2BlockStream.work (file:///home/santiago/Projects/aztec-3/yarn-project/stdlib/dest/block/l2_bloc 
k_stream/l2_block_stream.js:222:22)                                                                      
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)                       
    at async L2BlockStream.sync (file:///home/santiago/Projects/aztec-3/yarn-project/stdlib/dest/block/l 
2_block_stream/l2_block_stream.js:46:9)                                                                  
    at async BlockSynchronizer.doSync (file:///home/santiago/Projects/aztec-3/yarn-project/pxe/dest/bloc 
k_synchronizer/block_synchronizer.js:157:9)                                                              
[18:27:08.952] INFO: teardown-failure:pxe:service Simulating transaction execution request to 0xf04908a9 
 at 0x0000000000000000000000000000000000000000000000000000000000000004                                   
{"origin":"0x0000000000000000000000000000000000000000000000000000000000000004","functionSelector":"0xf04 
908a9","simulatePublic":true,"chainId":"0x0000000000000000000000000000000000000000000000000000000000aa36 
a7","version":"0x000000000000000000000000000000000000000000000000000000009a3a0b73","authWitnesses":["0x2 
983e158c25f7487e066bfa57d58f43340b2b45a114e6d6934dbc95213778ee6"]}                                       
[18:27:09.301] ERROR: teardown-failure:pxe:service TypeError: TypeError: Cannot read properties of       
undefined (reading 'value')                                                                              
    at formatProperty (node:internal/util/inspect:2280:12)                                               
    at formatRaw (node:internal/util/inspect:1176:9)                                                     
    at formatValue (node:internal/util/inspect:932:10)                                                   
    at inspect (node:internal/util/inspect:409:10)                                                       
    at formatErr                                                                                         
(file:///home/santiago/Projects/aztec-3/yarn-project/foundation/dest/log/pino-logger.js:326:29)          
    at Object.error                                                                                      
(file:///home/santiago/Projects/aztec-3/yarn-project/foundation/dest/log/pino-logger.js:56:97)           
    at L2BlockStream.work (file:///home/santiago/Projects/aztec-3/yarn-project/stdlib/dest/block/l2_bloc 
k_stream/l2_block_stream.js:222:22)                                                                      
    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)                       
    at async L2BlockStream.sync (file:///home/santiago/Projects/aztec-3/yarn-project/stdlib/dest/block/l 
2_block_stream/l2_block_stream.js:46:9)                                                                  
    at async BlockSynchronizer.doSync (file:///home/santiago/Projects/aztec-3/yarn-project/pxe/dest/bloc 
k_synchronizer/block_synchronizer.js:157:9)                                                              

Do not throw in the logger when we try to log something that fails
during serialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant