Skip to content

fix: for variable size keccak, inputs are zeroed after the requested length#632

Closed
guipublic wants to merge 3 commits intoacvm-backend-barretenbergfrom
gd/keccak_var_issue
Closed

fix: for variable size keccak, inputs are zeroed after the requested length#632
guipublic wants to merge 3 commits intoacvm-backend-barretenbergfrom
gd/keccak_var_issue

Conversation

@guipublic
Copy link

Description

Solves noir-lang/noir#1934

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • [] There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@kevaundray
Copy link

Can you PR this to master and then cherry-pick the commit from master onto acvm-backend-barretenberg instead?

@guipublic
Copy link
Author

guipublic commented Aug 1, 2023

I have created a new PR here: #646
for merging into master

@ludamad
Copy link
Collaborator

ludamad commented Feb 20, 2026

Closing: barretenberg development has moved to AztecProtocol/aztec-packages. This standalone repo is no longer maintained.

@ludamad ludamad closed this Feb 20, 2026
@ludamad ludamad deleted the gd/keccak_var_issue branch February 20, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants