FEAT: Adding TargetIdentifier
#1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValbuenaVC
reviewed
Jan 29, 2026
Contributor
ValbuenaVC
left a comment
ValbuenaVC
left a comment
There was a problem hiding this comment.
Minor comments, overall looks great!
rlundeen2
reviewed
Jan 29, 2026
rlundeen2
approved these changes
Jan 29, 2026
Contributor
rlundeen2
left a comment
rlundeen2
left a comment
There was a problem hiding this comment.
Looks great!
Can you make sure to run pytest .\tests\integration\memory\
And the Scorer Evals notebooks to make sure everything looks like it's working?
romanlutz
reviewed
Jan 29, 2026
romanlutz
approved these changes
Jan 29, 2026
romanlutz
reviewed
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
TargetIdentifierclasses and refactors the building of target identifiers across all prompt targets and now includestarget_specific_paramsas well as other granular identifying parameters. This follows the pattern ofScorerIdentifierandConverterIdentifierclasses.All classes that reference target identifiers now use the object and print a deprecation method if dict is used via the
normalizemethod inidentifier.py.Misc:
Tests and Documentation
Added and ran unit tests