FEAT: Dataset Loading Changes#1451
Merged
ValbuenaVC merged 47 commits intoAzure:mainfrom Mar 19, 2026
Merged
Conversation
rlundeen2
reviewed
Mar 11, 2026
rlundeen2
reviewed
Mar 11, 2026
ValbuenaVC
commented
Mar 12, 2026
rlundeen2
reviewed
Mar 13, 2026
rlundeen2
reviewed
Mar 13, 2026
rlundeen2
reviewed
Mar 13, 2026
rlundeen2
reviewed
Mar 13, 2026
Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
Co-authored-by: hannahwestra25 <hannahwestra@microsoft.com>
hannahwestra25
approved these changes
Mar 19, 2026
Contributor
hannahwestra25
left a comment
There was a problem hiding this comment.
lgtm thanks for addressing all my comments 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Features:
filtersargument to get_all_dataset_names, which rejects datasets that don't meet filter criteria.filtershas typeSeedDatasetFilters.SeedDatasetProviders have two options for storing static metadata (dynamic metadata, like derived attributes at runtime, has been scoped out of this PR):harm_categories), and use types likeSeedDatasetFoobar.*.promptfile as tags, and extracted from it.SeedDatasetMetadataacts as a unified schema and ground truth for logic related to parsing metadata, and we expect only a few class attributes to count as metadata.tags = {"all"}, all filtering logic is bypassed.Notes for Follow-Up PRs:
Tests and Documentation
test_seed_dataset_metadata.pyunder unit tests.test_seed_dataset_provider_integration.pyintests.integration.datasetsto account for local and remote metadata population.