DOC: updating copilot review instructions#1477
Open
rlundeen2 wants to merge 2 commits intoAzure:mainfrom
Open
Conversation
romanlutz
reviewed
Mar 16, 2026
| def __init__(self, *, target: PromptChatTarget, template: str = "default") -> None: | ||
| ... | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
shall we add a section on updating the modality table with the new converters https://azure.github.io/PyRIT/code/converters/converters/ ?
romanlutz
reviewed
Mar 16, 2026
|
|
||
| Tests should be readable, and it should be clear what is being tested and how. Tests should also be maintainable, and it should be easy to update them when the code changes. We should make sure we reuse code. If there are common patterns across tests, we should extract those into helper functions or fixtures. This makes it easier to write new tests and maintain existing ones. | ||
|
|
||
| ## Core Testing Requirements |
Contributor
There was a problem hiding this comment.
shall we add something about unit vs integration? Unit should not make network calls.
Anything that includes targets should test api key & entra auth.
romanlutz
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure this will be ongoing, but adding some instructions for it to be more choosey, and also giving it some converter and scenario specific guidance.
https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review