Open
Conversation
romanlutz
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes
read_jsonl()tolerate blank lines in JSONL input.Problem
read_jsonl()currently does a directjson.loads(line)for every line in the file.That means a JSONL file with an empty line or a whitespace-only separator fails immediately with
JSONDecodeError, even when every non-empty line is valid JSON.In practice, blank lines are common in generated or hand-edited JSONL files, especially at the end of a file or between entries during review.
Fix
Skip blank / whitespace-only lines before decoding:
This preserves the existing behavior for valid JSONL records while making the reader robust to common formatting noise.
Tests
Added regression coverage for a JSONL stream containing a blank line between two valid entries.
Validation command:
Validation result: