Skip to content

Handle empty CSV exports in remote dataset cache #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
biefan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle empty CSV exports in remote dataset cache #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyrit/common/csv_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ def write_csv(file: IO[Any], examples: list[dict[str, str]]) -> None:
file: A file-like object opened for writing CSV data.
examples (List[Dict[str, str]]): List of dictionaries to write as CSV rows.
"""
if not examples:
return

writer = csv.DictWriter(file, fieldnames=examples[0].keys())
writer.writeheader()
writer.writerows(examples)
9 changes: 9 additions & 0 deletions tests/unit/datasets/test_remote_dataset_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,12 @@ def test_write_cache_creates_directories(self, tmp_path):
loader._write_cache(cache_file=cache_file, examples=data, file_type="json")

assert cache_file.exists()

def test_write_cache_csv_allows_empty_examples(self, tmp_path):
loader = ConcreteRemoteLoader()
cache_file = tmp_path / "empty.csv"

loader._write_cache(cache_file=cache_file, examples=[], file_type="csv")

assert cache_file.exists()
assert cache_file.read_text(encoding="utf-8") == ""
Loading