feat: fix for privatednszone name in web/static-site/
#6305
Conversation
- Refactored several functions for improved readability. - Removed unused variables and imports throughout the codebase. - Updated comments to better reflect the current logic. - Ensured consistent formatting across all files.
avm-organizer
bot
added
the
Needs: Core Team 🧞
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
| name: '${uniqueString(deployment().name, location)}-staticSite-PrivateDnsZone' | ||
| params: { | ||
| name: 'privatelink.${staticSite.properties.defaultHostname}.azurestaticapps.net' | ||
| name: 'privatelink.${split(staticSite.properties.defaultHostname, '.')[1]}.azurestaticapps.net' |
There was a problem hiding this comment.
Hey @ChrisSidebotham assuming the defaultHostName has a value of like "happy-sea-15afae3e.azurestaticwebsites.net", would you not need to refer to the [0] item of the split array
[
happy-sea-15afae3e,
azurestaticwebsites,
net
]
?
2 participants
Description
Closes #5985
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.