Skip to content

Comments

feat: 콜벤 알림 단건 읽음 처리 & 일괄 삭제 API 추가#2157

Merged
DHkimgit merged 3 commits intodevelopfrom
feat/2156-callvan-sprint
Feb 24, 2026
Merged

feat: 콜벤 알림 단건 읽음 처리 & 일괄 삭제 API 추가#2157
DHkimgit merged 3 commits intodevelopfrom
feat/2156-callvan-sprint

Conversation

@DHkimgit
Copy link
Collaborator

@DHkimgit DHkimgit commented Feb 23, 2026

🔍 개요

  • 콜벤 알림 단건 읽음 처리 & 일괄 삭제 API 추가

🚀 주요 변경 내용


💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • New Features
    • Added notification management: Users can now mark individual notifications as read and delete notifications—either specific ones or clear all at once.

@github-actions github-actions bot added the Team Campus 캠퍼스 팀에서 작업할 이슈입니다 label Feb 23, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

📝 Walkthrough

Walkthrough

This PR introduces three new notification management endpoints to the Callvan domain. The changes add capabilities to mark individual notifications as read and delete notifications (individually or in bulk) across API, controller, service, and repository layers. Implementation uses soft deletes to preserve data integrity.

Changes

Cohort / File(s) Summary
API Contract
src/main/java/in/koreatech/koin/domain/callvan/controller/CallvanApi.java
Added three public interface method declarations for markNotificationAsRead, deleteAllNotifications, and deleteNotification with appropriate return types and parameter annotations.
Controller Implementation
src/main/java/in/koreatech/koin/domain/callvan/controller/CallvanController.java
Implemented three new endpoints (POST /notifications/{notificationId}/read, DELETE /notifications, DELETE /notifications/{notificationId}) with STUDENT authentication, delegating to service layer and returning 204 NO_CONTENT responses.
Service & Data Access
src/main/java/in/koreatech/koin/domain/callvan/service/CallvanNotificationService.java, src/main/java/in/koreatech/koin/domain/callvan/repository/CallvanNotificationRepository.java
Added three transactional service methods that delegate to four new or modified repository query methods. Modified existing updateIsReadByRecipientId query to exclude deleted notifications, added targeted update methods for marking single notifications as read and soft-deleting notifications (all or specific).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

📬 Ding! A message arrives with care,
Mark it read, then make it disappear!
One or many, swept away so clean,
Soft deletes keep what once has been.
The rabbit hops through notifications bright,
While STUDENT souls rest sound at night! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive Linked issue #2156 has no specific coding requirements defined; unable to validate if changes meet objectives. Review linked issue #2156 for specific requirements, or add detailed objectives to the issue for proper validation.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main changes: adding single notification read-marking and batch delete APIs for callvan notifications.
Out of Scope Changes check ✅ Passed All changes are focused on callvan notification APIs (mark single as read, batch delete, single delete) with supporting repository and service layer updates.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/2156-callvan-sprint

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/main/java/in/koreatech/koin/domain/callvan/controller/CallvanApi.java`:
- Around line 398-405: Update the Operation annotation's description on the
CallvanApi endpoint that handles POST "/notifications/{notificationId}/read"
(the method annotated with `@PostMapping`("/notifications/{notificationId}/read")
in class CallvanApi) to fix the user-facing typo by replacing "딘건" with "단건" in
the multi-line description string so the summary/description reads correctly for
the API documentation.

Comment on lines +398 to +405
@ApiResponseCodes({
NO_CONTENT
})
@Operation(summary = "콜밴 알림 단건 읽음 처리", description = """
### 콜밴 알림 딘건 읽음 처리 API
로그인한 사용자의 알림을 읽음 처리합니다.
""")
@PostMapping("/notifications/{notificationId}/read")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in Operation description ("딘건" → "단건").

Line 402 has a user-facing typo in the API description.

✍️ Proposed fix
-        ### 콜밴 알림 딘건 읽음 처리 API
+        ### 콜밴 알림 단건 읽음 처리 API
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/main/java/in/koreatech/koin/domain/callvan/controller/CallvanApi.java`
around lines 398 - 405, Update the Operation annotation's description on the
CallvanApi endpoint that handles POST "/notifications/{notificationId}/read"
(the method annotated with `@PostMapping`("/notifications/{notificationId}/read")
in class CallvanApi) to fix the user-facing typo by replacing "딘건" with "단건" in
the multi-line description string so the summary/description reads correctly for
the API documentation.

@github-actions
Copy link

Unit Test Results

673 tests   670 ✔️  1m 24s ⏱️
165 suites      3 💤
165 files        0

Results for commit e4db4ef.

@DHkimgit DHkimgit merged commit 3b26a2a into develop Feb 24, 2026
9 checks passed
@DHkimgit DHkimgit deleted the feat/2156-callvan-sprint branch February 24, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Campus 캠퍼스 팀에서 작업할 이슈입니다

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[캠퍼스] 디자인 변경 요구사항 적용

1 participant