feat: 콜벤 알림 단건 읽음 처리 & 일괄 삭제 API 추가#2157
Conversation
📝 WalkthroughWalkthroughThis PR introduces three new notification management endpoints to the Callvan domain. The changes add capabilities to mark individual notifications as read and delete notifications (individually or in bulk) across API, controller, service, and repository layers. Implementation uses soft deletes to preserve data integrity. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/java/in/koreatech/koin/domain/callvan/controller/CallvanApi.java`:
- Around line 398-405: Update the Operation annotation's description on the
CallvanApi endpoint that handles POST "/notifications/{notificationId}/read"
(the method annotated with `@PostMapping`("/notifications/{notificationId}/read")
in class CallvanApi) to fix the user-facing typo by replacing "딘건" with "단건" in
the multi-line description string so the summary/description reads correctly for
the API documentation.
| @ApiResponseCodes({ | ||
| NO_CONTENT | ||
| }) | ||
| @Operation(summary = "콜밴 알림 단건 읽음 처리", description = """ | ||
| ### 콜밴 알림 딘건 읽음 처리 API | ||
| 로그인한 사용자의 알림을 읽음 처리합니다. | ||
| """) | ||
| @PostMapping("/notifications/{notificationId}/read") |
There was a problem hiding this comment.
Fix typo in Operation description ("딘건" → "단건").
Line 402 has a user-facing typo in the API description.
✍️ Proposed fix
- ### 콜밴 알림 딘건 읽음 처리 API
+ ### 콜밴 알림 단건 읽음 처리 API🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/main/java/in/koreatech/koin/domain/callvan/controller/CallvanApi.java`
around lines 398 - 405, Update the Operation annotation's description on the
CallvanApi endpoint that handles POST "/notifications/{notificationId}/read"
(the method annotated with `@PostMapping`("/notifications/{notificationId}/read")
in class CallvanApi) to fix the user-facing typo by replacing "딘건" with "단건" in
the multi-line description string so the summary/description reads correctly for
the API documentation.
🔍 개요
🚀 주요 변경 내용
💬 참고 사항
✅ Checklist (완료 조건)
Summary by CodeRabbit