fix: expose connection identifier on connection objects#360
Merged
DimitriKwihangana merged 4 commits intomainfrom Feb 27, 2026
Merged
fix: expose connection identifier on connection objects#360DimitriKwihangana merged 4 commits intomainfrom
DimitriKwihangana merged 4 commits intomainfrom
Conversation
bramj
approved these changes
Feb 26, 2026
Contributor
bramj
left a comment
There was a problem hiding this comment.
Great @DimitriKwihangana ! This is really cool, I'm surprised it's such a small change.
Just a minor comment.
| """Abstract base class for connections.""" | ||
|
|
||
| pass | ||
| _: dataclasses.KW_ONLY |
Contributor
There was a problem hiding this comment.
This is very clever! I think it could benefit from a documentation comment explaining what it does. (this seems to explain it well: https://stackoverflow.com/a/49911616)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is about adding a slug/identifier of a connection to the connection class in addition to the url and variables
Changes
How/what to test