Skip to content

fix: expose connection identifier on connection objects#360

Merged
DimitriKwihangana merged 4 commits intomainfrom
HEXA-1274-connection-identifier-as-parameters
Feb 27, 2026
Merged

fix: expose connection identifier on connection objects#360
DimitriKwihangana merged 4 commits intomainfrom
HEXA-1274-connection-identifier-as-parameters

Conversation

@DimitriKwihangana
Copy link
Contributor

The fix is about adding a slug/identifier of a connection to the connection class in addition to the url and variables

Changes

  • I Added identifier field to the Connection base class and pass it through when constructing all connection types, so the identifier used to fetch a connection is accessible on the returned object.
  • Also fix IASOConnection to properly inherit from Connection.

How/what to test

  • Run any pipeline that uses a connection parameter. After fetching the connection, print or log .identifier on it. it should return the slug used to fetch it.

@DimitriKwihangana DimitriKwihangana self-assigned this Feb 19, 2026
Copy link
Contributor

@bramj bramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @DimitriKwihangana ! This is really cool, I'm surprised it's such a small change.
Just a minor comment.

"""Abstract base class for connections."""

pass
_: dataclasses.KW_ONLY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clever! I think it could benefit from a documentation comment explaining what it does. (this seems to explain it well: https://stackoverflow.com/a/49911616)

@DimitriKwihangana DimitriKwihangana merged commit 04ce390 into main Feb 27, 2026
6 checks passed
@DimitriKwihangana DimitriKwihangana deleted the HEXA-1274-connection-identifier-as-parameters branch February 27, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants