PlaudDeviceConnection._parseAudioChunk - RangeError crash#4546
PlaudDeviceConnection._parseAudioChunk - RangeError crash#4546
Conversation
Validate that payload has enough bytes before calling sublist to prevent RangeError when payload is truncated or corrupted. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Hey @aaravgarg! Thanks for this crash fix (PlaudDevice RangeError). Good write-up with Crashlytics data. We're tidying up stale PRs — this one has been open 8 days with an untested test plan (all checkboxes unchecked) and no screenshot/video demo of the fix working. Could you please run the test plan, check off the items, and add a quick screenshot or recording? Feel free to reopen once that evidence is added. Happy to review! |
|
Hey @aaravgarg 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
Summary
payload.sublist(9, 9 + length)to prevent RangeErrorCrash Stats
Test plan
🤖 Generated with Claude Code