Skip to content

PlaudDeviceConnection._parseAudioChunk - RangeError crash#4546

Closed
aaravgarg wants to merge 1 commit intomainfrom
fix/android-crash-plaud-parse-audio-range-error
Closed

PlaudDeviceConnection._parseAudioChunk - RangeError crash#4546
aaravgarg wants to merge 1 commit intomainfrom
fix/android-crash-plaud-parse-audio-range-error

Conversation

@aaravgarg
Copy link
Copy Markdown
Collaborator

Summary

  • Add bounds check before payload.sublist(9, 9 + length) to prevent RangeError
  • Return null when payload is truncated or corrupted instead of crashing

Crash Stats

Test plan

  • Verify Plaud audio streaming still works correctly
  • Test with corrupted BLE payload (should return null, not crash)

🤖 Generated with Claude Code

Validate that payload has enough bytes before calling sublist to
prevent RangeError when payload is truncated or corrupted.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@aaravgarg aaravgarg requested a review from mdmohsin7 February 1, 2026 23:28
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@beastoin
Copy link
Copy Markdown
Collaborator

Hey @aaravgarg! Thanks for this crash fix (PlaudDevice RangeError). Good write-up with Crashlytics data.

We're tidying up stale PRs — this one has been open 8 days with an untested test plan (all checkboxes unchecked) and no screenshot/video demo of the fix working.

Could you please run the test plan, check off the items, and add a quick screenshot or recording? Feel free to reopen once that evidence is added. Happy to review!

@beastoin beastoin closed this Feb 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hey @aaravgarg 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

  • Project standards — Ensuring consistency across the codebase
  • User needs — Making sure changes align with what our users need
  • Code best practices — Maintaining code quality and maintainability
  • Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants