Skip to content

Merge comparisons with 'in' #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrancescAlted merged 1 commit into from
Feb 9, 2026
Merged

Merge comparisons with 'in' #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/blosc2/lazyexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,9 @@ def reduce_slices( # noqa: C901
nblocks = res_eval.nbytes // res_eval.blocksize
# Initialize aux_reduc based on the reduction operation
# Padding blocks won't be written, so initial values matter for the final reduction
if reduce_op == ReduceOp.SUM or reduce_op == ReduceOp.ANY:
if reduce_op in {ReduceOp.SUM, ReduceOp.ANY}:
aux_reduc = np.zeros(nblocks, dtype=dtype)
elif reduce_op == ReduceOp.PROD or reduce_op == ReduceOp.ALL:
elif reduce_op in {ReduceOp.PROD, ReduceOp.ALL}:
aux_reduc = np.ones(nblocks, dtype=dtype)
elif reduce_op == ReduceOp.MIN:
if np.issubdtype(dtype, np.integer):
Expand Down Expand Up @@ -2203,7 +2203,7 @@ def reduce_slices( # noqa: C901
continue

if where is None:
if expression == "o0" or expression == "(o0)":
if expression in {"o0", "(o0)"}:
# We don't have an actual expression, so avoid a copy except to make contiguous
result = np.require(chunk_operands["o0"], requirements="C")
else:
Expand Down Expand Up @@ -2233,7 +2233,7 @@ def reduce_slices( # noqa: C901
result = np.any(result, **reduce_args)
elif reduce_op == ReduceOp.ALL:
result = np.all(result, **reduce_args)
elif reduce_op == ReduceOp.ARGMAX or reduce_op == ReduceOp.ARGMIN:
elif reduce_op in {ReduceOp.ARGMAX, ReduceOp.ARGMIN}:
# offset for start of slice
slice_ref = (
starts
Expand Down
Loading