Skip to content

fix: enforce maximumDepth for nested objects with array replacers #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chamath-Adithya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enforce maximumDepth for nested objects with array replacers #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,9 @@ function configure (options) {
stack.pop()
return `[${res}]`
}
if (maximumDepth < stack.length + 1) {
return '"[Object]"'
}
stack.push(value)
let whitespace = ''
if (spacer !== '') {
Expand Down
8 changes: 7 additions & 1 deletion test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,11 +910,17 @@ test('maximumDepth config', function (assert) {
assert.equal(result, '{"a":{"a":"[Array]","b":"[Object]"}}')

const res2 = serialize(obj, ['a', 'b'])
assert.equal(res2, '{"a":{"a":"[Array]","b":{}}}')
assert.equal(res2, '{"a":{"a":"[Array]","b":"[Object]"}}')

const json = JSON.stringify(obj, ['a', 'b'])
assert.equal(json, '{"a":{"a":[1,2,3],"b":{}}}')

const serializeDepth1 = stringify.configure({
maximumDepth: 1
})
const resDepth1 = serializeDepth1(obj, ['a', 'b'])
assert.equal(resDepth1, '{"a":"[Object]"}')

const res3 = serialize(obj, null, 2)
assert.equal(res3, `{
"a": {
Expand Down