CI: Deploy variables.bat to Windows CI environment#1081
Closed
x15sr71 wants to merge 1 commit intoCCExtractor:masterfrom
Closed
CI: Deploy variables.bat to Windows CI environment#1081x15sr71 wants to merge 1 commit intoCCExtractor:masterfrom
x15sr71 wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
|
Member
|
This is no viable approach. Those variables can be variable, and might not correspond to what's in the repository. I've updated the actual variables.bat file on the platform to include your fix from the previous PR. |
Contributor
Author
|
Thanks @canihavesomecoffee for clarifying and updating variables.bat directly on the platform! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Problem:
Current deployment pipeline (
.github/workflows/sp-deployment-pipeline.yml) copiesrunCI.batbut skipsvariables.bat:sudo cp "install/ci-vm/ci-windows/ci/runCI.bat" ... 2>/dev/null || true→
variables.batis not deployed alongsiderunCI.bat, which can lead to inconsistent configuration in the Windows CI environment. SincerunCI.batdepends onvariables.bat, this prevents updated values like%tempFolder%from taking effect.Fix:
Add deployment step for
variables.batsudo cp "install/ci-vm/ci-windows/ci/variables.bat" "${SAMPLE_REPOSITORY}/TestData/ci-windows/variables.bat" 2>/dev/null || true→ Ensures Windows CI deployment remains consistent with the existing Linux CI setup.