Skip to content

CI: Deploy variables.bat to Windows CI environment#1081

Closed
x15sr71 wants to merge 1 commit intoCCExtractor:masterfrom
x15sr71:fix/windows-ci-variables
Closed

CI: Deploy variables.bat to Windows CI environment#1081
x15sr71 wants to merge 1 commit intoCCExtractor:masterfrom
x15sr71:fix/windows-ci-variables

Conversation

@x15sr71
Copy link
Copy Markdown
Contributor

@x15sr71 x15sr71 commented Mar 29, 2026

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Problem:

Current deployment pipeline (.github/workflows/sp-deployment-pipeline.yml) copies runCI.bat but skips variables.bat:

sudo cp "install/ci-vm/ci-windows/ci/runCI.bat" ... 2>/dev/null || true

variables.bat is not deployed alongside runCI.bat, which can lead to inconsistent configuration in the Windows CI environment. Since runCI.bat depends on variables.bat, this prevents updated values like %tempFolder% from taking effect.

Fix:

Add deployment step for variables.bat

sudo cp "install/ci-vm/ci-windows/ci/variables.bat" "${SAMPLE_REPOSITORY}/TestData/ci-windows/variables.bat" 2>/dev/null || true

→ Ensures Windows CI deployment remains consistent with the existing Linux CI setup.

@sonarqubecloud
Copy link
Copy Markdown

@canihavesomecoffee
Copy link
Copy Markdown
Member

This is no viable approach. Those variables can be variable, and might not correspond to what's in the repository.

I've updated the actual variables.bat file on the platform to include your fix from the previous PR.

@x15sr71
Copy link
Copy Markdown
Contributor Author

x15sr71 commented Mar 29, 2026

Thanks @canihavesomecoffee for clarifying and updating variables.bat directly on the platform!

@x15sr71 x15sr71 deleted the fix/windows-ci-variables branch March 29, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants