[IMPROVEMENT] Add test case for cascade-failure behavior in nicediff#1088
Open
Hell1213 wants to merge 2 commits intoCCExtractor:masterfrom
Open
[IMPROVEMENT] Add test case for cascade-failure behavior in nicediff#1088Hell1213 wants to merge 2 commits intoCCExtractor:masterfrom
Hell1213 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



[IMPROVEMENT]
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Adds test case to document cascade-failure behavior in nicediff comparison algorithm.
Fixes #1087
What This Does
When comparing subtitle files where one file is missing an entry, the current line-by-line comparison causes all subsequent lines to mismatch. This test documents that behavior for future reference when implementing the frame-offset-tolerant comparison algorithm planned for the GSoC Sample Platform NG project.
Changes
Added
test_cascade_failure_missing_entry()totests/test_test/test_diff.pythat creates a scenario where subtitle entry 2 is missing and verifies the cascade behavior occurs.Testing
All tests pass.