-
Notifications
You must be signed in to change notification settings - Fork 150
feat: added permission request screen #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
*Also updated a test to match the current changes |
|
@BrawlerXull i have resolved all the test and analyze errors. the 2 tests failing are related to another issue i mentioned here. |
|
I've reviews some changes |
|
@BrawlerXull I have updated according to all the requirements:
Please let me know if any more refactors needed. |
Pavel401
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rohansen856
feat: added permission request screen
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixes #412
lib/app/modelsfolder usingget-cliand edited accordinglyroutesfolder to add the permission screen pathmain.dartfile so that permissions are not requested at the app start.Replace
issue_nowith the issue number which is fixed in this PRScreenshots
Example in linux device:
Screencast.from.2025-01-13.00-07-04.webm
Example in android device:
WhatsApp.Video.2025-01-13.at.12.11.07.AM.mp4
Final UI:
Checklist