Merged
Conversation
Whenever a CH client is listening before a CH endpoint is created by the server, a deadlock happens where the server's CH thread tries to grab the config READ lock for a second time in ignored mod check (grabs it for the 1st time in ch_client_thread). The config applying thread then gets hung up in apply_diff on WRITE lock acquisition. This commit removes the 2nd READ lock acquisition of the CH thread, removing the deadlock scenario. Fixes CESNET/netopeer2#1787
michalvasko
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CESNET/netopeer2#1787