FIREFLY-2070: Ensure only single local result file are used. - #1988
Merged
Conversation
robyww
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-2070
The Rubin TAP service may return multiple results, some of which contain invalid URIs. The current implementation uses the first result (e.g,
262) as the lookup key, which can coincidentally match a sub-directory in the upload directory.Update the logic to process only jobs that contain exactly one result URL, and verify that the referenced path both exists and is a regular file before using it.
Test: https://firefly-2070-uws-result-url.irsakubedev.ipac.caltech.edu/suit/