Implement Add/Edit/Delete Segment List Modals 2#2353
Conversation
|
The PR is now ready for review. |
frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
Show resolved
Hide resolved
|
@bcb37 Just to clarify, did you try the app on branch |
Yeah I was looking at the old one. Sorry. I'll do a real review now! |
@zackcl Ok, not only does this work flawlessly, but it fixes the other issue I was talking about on slack! |
|
approving also, only thing I see is just adding the new endpoint to the |
Resolves #2336, resolves #2257, resolves #2258, resolves #2338
Changes Include:
addSegmentListendpoint URL (/segments/list) to environment filesaddSegmentList,updateSegmentList, anddeleteSegmentListfunctions tosegments.data.service.tsfor making requests to the backendflagIdtoidinPrivateSegmentListRequestinterface for supporting both feature flags and segmentsflagIdtoidinFeatureFlagListValidatorfor consistency with the frontendSegmentController.test.tsfeature-flag-exclusions-section-card.component.tsEndpoints used for adding, updating, and deleting a segment list:
On ADD:
POST
/segments/listOn EDIT:
POST
/segmentOn DELETE:
DELETE
/segments/list/:segmentId