Skip to content

[ENG-11254] Improve local dev with mailhog configuration#11749

Merged
cslzchen merged 1 commit into
CenterForOpenScience:feature/pbs-26-9from
Ostap-Zherebetskyi:fix/local_mail
May 25, 2026
Merged

[ENG-11254] Improve local dev with mailhog configuration#11749
cslzchen merged 1 commit into
CenterForOpenScience:feature/pbs-26-9from
Ostap-Zherebetskyi:fix/local_mail

Conversation

@Ostap-Zherebetskyi
Copy link
Copy Markdown
Collaborator

@Ostap-Zherebetskyi Ostap-Zherebetskyi commented May 21, 2026

Ticket

Purpose

Refactor Notification.send method

Changes

Side Effects

QE Notes

CE Notes

Documentation

Copy link
Copy Markdown
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ⭐

Need to wait for the feature pb&s branch to be updated before merge.

@cslzchen cslzchen changed the title [] Refactor Notification.send method [ENG-11254] Improve local dev with mailhog configuration May 21, 2026
@cslzchen cslzchen marked this pull request as ready for review May 21, 2026 13:49
Comment thread osf/models/notification.py Outdated
Comment thread osf/models/notification.py Outdated
Comment thread osf/models/notification.py Outdated
Copy link
Copy Markdown
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cslzchen cslzchen merged commit 7d72518 into CenterForOpenScience:feature/pbs-26-9 May 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants