Skip to content

CLI fix to eliminate self amplifying rate limits(AST-159742) #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-atish-jadhav wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLI fix to eliminate self amplifying rate limits(AST-159742) #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b34953
AST CLI fix to eliminate self amplifying rate limits
cx-rakesh-kadu Jul 1, 2026
c5e8869
Merge branch 'main' into feature/rate-limit
cx-rakesh-kadu Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/wrappers/feature-flags-http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ import (
"encoding/json"
"fmt"
"net/http"
"strconv"
"strings"
"time"

"github.com/checkmarx/ast-cli/internal/logger"
"github.com/pkg/errors"
"github.com/spf13/viper"

Expand Down Expand Up @@ -87,6 +90,16 @@ func (f FeatureFlagsHTTPWrapper) GetSpecificFlag(flagName string) (*FeatureFlagR
return &model, nil
case http.StatusNotFound:
return nil, errors.New("feature flags not found")
case http.StatusTooManyRequests:
waitSeconds := defaultRateLimitWaitSeconds
if retryAfter := resp.Header.Get("Retry-After"); retryAfter != "" {
if parsed, parseErr := strconv.Atoi(retryAfter); parseErr == nil && parsed > 0 {
waitSeconds = parsed
}
}
logger.PrintIfVerbose(fmt.Sprintf("Feature flags rate limited (429). Waiting %d seconds before retry.", waitSeconds))
time.Sleep(time.Duration(waitSeconds) * time.Second)
return nil, errors.New("failed to load feature flags for tenant")
default:
return nil, errors.New("failed to load feature flags for tenant")
}
Expand Down
6 changes: 4 additions & 2 deletions internal/wrappers/feature-flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ func GetSpecificFeatureFlag(featureFlagsWrapper FeatureFlagsWrapper, flagName st
if len(featureFlags) == 0 || DefaultFFLoad {
_ = HandleFeatureFlags(featureFlagsWrapper)
}
// Take the value from FeatureFlags
return &FeatureFlagResponseModel{Name: flagName, Status: featureFlags[flagName]}, nil
defaultValue := featureFlags[flagName]
featureFlagsCache[flagName] = defaultValue // prevent re-fetch on next call
return &FeatureFlagResponseModel{Name: flagName, Status: defaultValue}, nil

}

UpdateSpecificFeatureFlagMap(flagName, *specificFlag)
Expand Down
Loading