take 2 of ccache for emscripten build#71439
Merged
Maleclypse merged 22 commits intoCleverRaven:masterfrom Feb 18, 2024
Merged
Conversation
github-actions
Bot
added
Code: Build
github-actions
Bot
added
astyled
github-actions
Bot
added
the
BasicBuildPassed
…rRaven#71524) This reverts commit ef75f20.
nornagon
changed the title
Contributor
Author
|
Alright, this is finally working. Found a couple of bugs in emsdk and the ccache fork while I was at it, see emscripten-core/emsdk#1345 and juj/ccache#3. The weird $PATH stuff is working around the emsdk bug, and EM_CONFIG needs to be set to prevent the forked ccache from crashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
ccache wasn't actually being invoked. Also, per https://github.com/emscripten-core/emscripten/pull/13681/files, ccache + emscripten apparently needs a special fork to work correctly.
Describe the solution
Describe alternatives you've considered
Testing
Additional context