Skip to content

chore(memtrack): lower on-demand attach log to debug#462

Merged
not-matthias merged 1 commit into
mainfrom
cod-1801-only-attach-to-used-libraries-in-memtrack-2
Jul 20, 2026
Merged

chore(memtrack): lower on-demand attach log to debug#462
not-matthias merged 1 commit into
mainfrom
cod-1801-only-attach-to-used-libraries-in-memtrack-2

Conversation

@not-matthias

Copy link
Copy Markdown
Member

Summary

Downgrades the per-attach "on-demand attached N probes to ..." log from info! to debug! in attach_worker.rs.

This message fires once per successfully attached mapping during on-demand allocator attachment, which is too noisy for the default info level. It belongs at debug.

Testing

  • cargo build

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown

Greptile Summary

This PR reduces noise from memtrack on-demand attach logging.

  • Changes the successful per-mapping attach message from info! to debug!.
  • Leaves attach failure handling and error logging unchanged.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The failure path still returns an error and logs at error level.
  • Tests do not assert on this success log.

Important Files Changed

Filename Overview
crates/memtrack/src/ebpf/attach_worker.rs Changed the successful on-demand probe attachment log from info level to debug level.

Reviews (1): Last reviewed commit: "chore(memtrack): lower on-demand attach ..." | Re-trigger Greptile

@not-matthias
not-matthias marked this pull request as ready for review July 20, 2026 13:39
@codspeed-hq

codspeed-hq Bot commented Jul 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 17 untouched benchmarks


Comparing cod-1801-only-attach-to-used-libraries-in-memtrack-2 (26fb4b5) with main (6794d28)

Open in CodSpeed

@not-matthias
not-matthias merged commit 26fb4b5 into main Jul 20, 2026
23 checks passed
@not-matthias
not-matthias deleted the cod-1801-only-attach-to-used-libraries-in-memtrack-2 branch July 20, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants