[Bungee] Change PlayerDisconnectEvent priority to LOWEST#536
Open
karer wants to merge 2 commits intoCodeCrafter47:masterfrom
Open
[Bungee] Change PlayerDisconnectEvent priority to LOWEST#536karer wants to merge 2 commits intoCodeCrafter47:masterfrom
karer wants to merge 2 commits intoCodeCrafter47:masterfrom
Conversation
Owner
|
The code you remove is there as a workaround for the following BungeeCord bug: SpigotMC/BungeeCord#1601. |
Owner
|
I'd be okay with the priority change if that helps. |
|
Just so that nobody pulls this without considering this: Changing the priority from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting server to null could cause problems with other plugins. E.g. with auth, which stores player's latest server in database. It has normal priority and gets current server as 'null', because of BungeeTabListPlus.
This PR:
... so other plugins get valid info about current server.