Skip to content

Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 1 | Extra long blooms#156

Open
katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
katarzynakaz:extra-long-blooms
Open

Glasgow | 25 SDC NOV | Katarzyna Kazimierczuk | Sprint 1 | Extra long blooms#156
katarzynakaz wants to merge 4 commits intoCodeYourFuture:mainfrom
katarzynakaz:extra-long-blooms

Conversation

@katarzynakaz
Copy link

@katarzynakaz katarzynakaz commented Feb 22, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Changes the length of chars.

@katarzynakaz katarzynakaz added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 22, 2026
@OracPrime OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 28, 2026
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for the actual change asked for is fine. However you've polluted the PR with a whole load of other changes. This would not be accepted in a professional environment

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Purple Forest Kanban Feb 28, 2026
@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 28, 2026
@katarzynakaz katarzynakaz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not happy that users.py and profile.mjs are showing up as changed

@OracPrime OracPrime removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@katarzynakaz
Copy link
Author

changed as requested

@katarzynakaz katarzynakaz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels Mar 4, 2026
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted!

@OracPrime OracPrime added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. NotCoursework Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants