Skip to content

London | November 25 | Donara Blanc | Sprint 1 | Fix profile page login#167

Open
donarbl wants to merge 1 commit intoCodeYourFuture:mainfrom
donarbl:sprint1-log-profile
Open

London | November 25 | Donara Blanc | Sprint 1 | Fix profile page login#167
donarbl wants to merge 1 commit intoCodeYourFuture:mainfrom
donarbl:sprint1-log-profile

Conversation

@donarbl
Copy link

@donarbl donarbl commented Feb 27, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • [x ] My changes follow the style guide

Changelist

  • Fixed login on profile page by listening for form submit event instead of button click event
  • This resolves the 501 error when logging in from a profile page

@donarbl donarbl added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Legacy-Code The name of the module. labels Feb 28, 2026
OracPrime
OracPrime approved these changes Mar 13, 2026
View reviewed changes
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good PR.

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@OracPrime OracPrime OracPrime approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Legacy-Code The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

Purple Forest Kanban
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@donarbl @OracPrime